[
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387649#comment-16387649
]
ASF GitHub Bot commented on CLOUDSTACK-10317:
---------------------------------------------
ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix
SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172464559
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
##########
@@ -388,7 +388,7 @@ def fw_router(self):
self.fw.append(["mangle", "",
"-A VPN_%s -j RETURN" % self.address['public_ip']])
self.fw.append(["nat", "",
- "-A POSTROUTING -o eth2 -j SNAT --to-source %s" %
self.address['public_ip']])
+ "-A POSTROUTING -o %s -j SNAT --to-source %s" %
(self.dev, self.address['public_ip'])])
Review comment:
@rhtyd what we are using are
```
diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
index e6aea26..d336e0a 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
@@ -400,7 +400,7 @@ class CsIP:
self.fw.append(["mangle", "",
"-A VPN_%s -j RETURN" %
self.address['public_ip']])
self.fw.append(["nat", "",
- "-A POSTROUTING -o eth2 -j SNAT --to-source %s"
% self.address['public_ip']])
+ "-A POSTROUTING -o %s -j SNAT --to-source %s" %
(self.dev, self.cl.get_eth2_ip())])
self.fw.append(["mangle", "",
"-A PREROUTING -i %s -m state --state NEW " %
self.dev +
"-j CONNMARK --set-xmark %s/0xffffffff" %
self.dnum])
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> In case of multiple-public ips, snat fails to work for addtional public
> nics/network for guest traffic
> ------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed
> correctly for traffic towards additional public nics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
