[
https://issues.apache.org/jira/browse/CLOUDSTACK-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447296#comment-16447296
]
ASF GitHub Bot commented on CLOUDSTACK-10359:
---------------------------------------------
nitin-maharana commented on a change in pull request #2591: CLOUDSTACK-10359:
Change the inconsistent method names.
URL: https://github.com/apache/cloudstack/pull/2591#discussion_r183244181
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -194,7 +194,7 @@ public String getHostTag() {
return hostTag;
}
- public Boolean getIsSystem() {
+ public Boolean isSystem() {
Review comment:
This will give the compilation error, as the changes in all usages are
missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method names
> -------------------------
>
> Key: CLOUDSTACK-10359
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10359
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: KuiLIU
> Priority: Major
>
> The following two methods are named "getXXX".
> The two method are checking the status of variables.
> "getCustomized" is not as intuitive as "isCustomized".
> "getIsSystem" is not as intuitive as "isSystem" as well.
> {code:java}
> public boolean getCustomized() {
> return (cpuNumber == null || memory == null || cpuSpeed == null);
> }
> public Boolean getIsSystem() {
> return isSystem == null ? false : isSystem;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
