[
https://issues.apache.org/jira/browse/CLOUDSTACK-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461110#comment-16461110
]
ASF GitHub Bot commented on CLOUDSTACK-10232:
---------------------------------------------
khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232:
SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r185519409
##########
File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
##########
@@ -64,10 +71,17 @@ config_guest() {
get_boot_params() {
case $HYPERVISOR in
- xen-domU|xen-hvm)
+ xen-pv)
cat /proc/cmdline > $CMDLINE
sed -i "s/%/ /g" $CMDLINE
;;
+ xen-hvm)
+ if [ ! -f /usr/sbin/xenstore-read ]; then
+ log_it "ERROR: xentools not installed, cannot found xenstore-read"
&& exit 5
+ fi
+ /usr/sbin/xenstore-read vm-data/cloudstack/init >
/var/cache/cloud/cmdline
Review comment:
That's strange, I really don't know what's going on. I just checked dozens
of random VMs, on various Xenserver version (7.x.x+ though) and all of them had
`xenstore-read` in both places! I guess using `/usr/bin` would be safer. or
even check both places then log an error?
BTW I wrote a comment on your PR as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SystemVMs and VR to run as HVM on XenServer
> -------------------------------------------
>
> Key: CLOUDSTACK-10232
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10232
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM, Virtual Router, XenServer
> Affects Versions: 4.10.0.0, 4.9.3.0
> Reporter: Pierre-Luc Dion
> Priority: Major
>
> Following the recent Meltdown-Spectre security risk,one of the mitigation,as
> of Jan 2018, for XenServer Hypervisor is to run Virtual-Machine in HVM mode.
> Currently SystemVMs and Virtual-Routers run as PV on XenServer and the eth0
> is configured using {{/etc/init.d/cloud-early-config}} using grub params from
> {{/proc/cmdline}}. When VM run as HVM, it is not possible to push initial
> boot instruction via pygrub.
> Quick tests has been done using xenstore and it look like it would be
> possible to send same initial boot instruction has pygrub but using xenstore
> for HVM instances.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
