[
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472233#comment-16472233
]
ASF GitHub Bot commented on CLOUDSTACK-10276:
---------------------------------------------
rafaelweingartner commented on a change in pull request #2639:
[CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#discussion_r187668341
##########
File path:
api/src/org/apache/cloudstack/api/command/admin/volume/ListVolumesCmdByAdmin.java
##########
@@ -34,32 +34,5 @@
@APICommand(name = "listVolumes", description = "Lists all volumes.",
responseObject = VolumeResponse.class, responseView = ResponseView.Full,
entityType = {Volume.class},
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
public class ListVolumesCmdByAdmin extends ListVolumesCmd {
- public static final Logger s_logger =
Logger.getLogger(ListVolumesCmdByAdmin.class.getName());
-
- @Parameter(name=ApiConstants.POD_ID, type=CommandType.UUID,
entityType=PodResponse.class,
- description="the pod id the disk volume belongs to")
- private Long podId;
Review comment:
It is in the superclass as well. These parameters were declared twice. One
in the "admin" class, and other in the "normal" one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> View volumes from primary storage not working when storage UUID is not a UUID
> -----------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10276
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rafael Weingärtner
> Assignee: Rafael Weingärtner
> Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of
> the storage that is going to be used by ACS and is already set up in the
> host. The problem is that we can use any String of characters there, and this
> String does not need to be a UUID one. When listing volumes from a primary
> storage that has such conditions, the list will return all of the volumes in
> the cloud because the ad-hoc “API framework” will ignore that value as it is
> not a UUID type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
