[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483722#comment-16483722
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10276:
---------------------------------------------

rafaelweingartner commented on issue #2639: [CLOUDSTACK-10276] listVolumes not 
working when storage UUID is not a UUID
URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390929227
 
 
   I really do not see any other smaller/simpler solution for this issue. 
Moreover, it does not affect/break anything in the client side. The client is 
already seeing an ID, which is a UUID.
   
   The changes are only internal to ACS. I changed the type of `storageId` from 
`long` to `String` to avoid using that method that converts the given UUID to 
an internal database ID. That method is validating the input, and ignoring 
anything that is not an UUID. Then, I am using the UUID as the filter at 
`QueryManagerImpl.java`.
   
   The changed lines are only 2. The other lines are a result of a code cleanup 
that I did, and the code formatting I applied.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> View volumes from primary storage not working when storage UUID is not a UUID
> -----------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10276
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10276
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rafael Weingärtner
>            Assignee: Rafael Weingärtner
>            Priority: Major
>
> When configuration a pre-setup primary storage we can enter the name-label of 
> the storage that is going to be used by ACS and is already set up in the 
> host. The problem is that we can use any String of characters there, and this 
> String does not need to be a UUID one. When listing volumes from a primary 
> storage that has such conditions, the list will return all of the volumes in 
> the cloud because the ad-hoc “API framework” will ignore that value as it is 
> not a UUID type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to