[
https://issues.apache.org/jira/browse/CLOUDSTACK-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591084#comment-16591084
]
ASF GitHub Bot commented on CLOUDSTACK-10365:
---------------------------------------------
blueorangutan commented on issue #2816: CLOUDSTACK-10365: Change the "getXXX"
boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2816#issuecomment-415635962
<b>Trillian test result (tid-2959)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57118 seconds
Marvin logs:
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2816-t2959-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected:
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 63 look OK, 6 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1646.35 |
test_accounts.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 |
test_deploy_virtio_scsi_vm.py
test_02_vpc_privategw_static_routes | `Failure` | 205.44 |
test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1307.31 |
test_privategw_acl.py
test_02_unsecure_vm_migration | `Error` | 77.64 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 3655.86 |
test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 58.79 |
test_vm_life_cycle.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 527.87 |
test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 403.23 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 428.75 | test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.83 |
test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent boolean-related method names
> -----------------------------------------
>
> Key: CLOUDSTACK-10365
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10365
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: KuiLIU
> Priority: Major
>
> These boolean-return methods are named as "getXXX".
> Other boolean-return methods are named as "isXXX".
> Considering there methods will return boolean values, it should be more clear
> to rename them as "isXXX".
> {code:java}
> public boolean getEnableRRS() {
> return enableRRS;
> }
> public boolean getEnableRRS() {
> return enableRRS;
> }
> public boolean getShrinkOk() {
> return shrinkOk;
> }
>
> public boolean getSourceNat() {
> return sourceNat;
> }
>
> public boolean getInternalLb() {
> return internalLb;
> }
>
> public boolean getOfferHA() {
> return offerHA;
> }
>
> public boolean getVolatileVm() {
> return volatileVm;
> }
>
> public boolean getIsUserDefined() {
> return isUserDefined;
> }
>
> public boolean getEnablePassword() {
> return enablePassword;
> }
>
> public boolean getEnableSshKey() {
> return enableSshKey;
> }
>
> public boolean getUuidTranslation() {
> return _doUuidTranslation;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
