*Utils methods should not be extensible or able to be instantiated. -------------------------------------------------------------------
Key: COLLECTIONS-276 URL: https://issues.apache.org/jira/browse/COLLECTIONS-276 Project: Commons Collections Issue Type: Improvement Affects Versions: Generics Reporter: Stephen Kestle Priority: Minor Fix For: Generics I don't see any good reason why this CollectionUtils (and others) isn't final with a private constructor. There are no non-static methods, and any extension of them is going to have to call through to the super to avoid compiler warnings. e.g. MyCollectionUtils.select() will provoke the warning that "static methods should be called directly" (on CollectionUtils). Which would mean MyCollectionUtils{ public static Collection select(){ return CollectionUtils.select(); } Which really defeats the purpose. In Java5, we have static imports now - these provide more benefit than previous extension did anyhow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.