[ https://issues.apache.org/jira/browse/COLLECTIONS-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541746 ]
Frank Hefter commented on COLLECTIONS-246: ------------------------------------------ I don't want to make a new attachment for a small but useful addition. Maybe the next editor can add these lines then: --------------------------------------------------------------------------------------------------- /** * Just indicates the selection of the first entry in the list. * This is good to indicate that the start of the list has been reached. * @return * @version initial Frank Hefter 2007-11-12 */ public boolean isFirst() { return currentIndex<=0; } /** * Just indicates the selection of the last entry in the list. * This is good to indicate that the end of the list has been reached. * @return * @version initial Frank Hefter 2007-11-12 */ public boolean isLast() { return currentIndex>=list.size()-1; } --------------------------------------------------------------------------------------------------- > LoopingListIterator behaves unexpected on next and previous mixed > ----------------------------------------------------------------- > > Key: COLLECTIONS-246 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-246 > Project: Commons Collections > Issue Type: Bug > Components: Iterator > Affects Versions: 3.2 > Environment: JDK 1.4.2_12 > Common Collections 3.2 > Reporter: Frank Hefter > Priority: Blocker > Attachments: LoopingListIterator.java, LoopingListIterator.java, > LoopingListIterator.java, LoopingListIteratorTest.java > > > Using ArrayList as the backing list. > This combination at least returns unexpected results as you can see in the > testcase below. > I used this for a list navigator in a web frontend and had trouble with users. > I suspect java.util.AbstrList$ListItr (role of "cursor" var seems to be wrong > implemented ) to cause this problem. If so maybe we have to implement it in a > different way. > Testcase (it runs without hassle but the comments show whats wrong): > ------------------------------------------- > import java.util.ArrayList; > import junit.framework.TestCase; > import org.apache.commons.collections.iterators.LoopingListIterator; > public class SelectionControllerTest extends TestCase { > public void testSelectorForApache() { > ArrayList al = new ArrayList(); > al.add("0"); al.add("1"); al.add("2"); > LoopingListIterator it = new LoopingListIterator(al); > assertEquals("0", it.next()); // This is OK > // here I am on "0" > assertEquals("0", it.previous()); // Wrong ! This should be 2! > // here I am on "0" too! This is wrong. > assertEquals("2", it.previous()); > assertEquals("1", it.previous()); > assertEquals("0", it.previous()); > assertEquals("2", it.previous()); > // here I am on "2" > assertEquals("2", it.next()); // Wrong ! This should be 0! > // here I am on "2" too! This is wrong. > assertEquals("0", it.next()); > assertEquals("1", it.next()); > // here I am on "1" > assertEquals("1", it.previous()); // Wrong ! This should be 0! > } > } > ------------------------------------------- > Thanks for your help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.