[ https://issues.apache.org/jira/browse/IO-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549003 ]
Sebb commented on IO-143: ------------------------- For example, see CanReadFileFilter, FileDeleteStrategy etc. These also have protected constructors, but perhaps private is better here. > [PATCH] Added Singleton Constants in several stream classes > ----------------------------------------------------------- > > Key: IO-143 > URL: https://issues.apache.org/jira/browse/IO-143 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers > Affects Versions: 1.4, AFTER-1.4 > Environment: jvm compliant os > Reporter: Nikunj Trivedi > Fix For: 1.4, AFTER-1.4 > > Attachments: closed_input_stream.patch, closed_output_stream.patch, > null_output_stream.patch, null_writer.patch > > > I have added singleton constants in following four classes which should have > been singleton. > ClosedInputStream > ClosedOutputStream > NullOutputStream > NullWriter > We may also make it a singleton by keeping constructor private, if required. > Please comment/commit. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.