[ 
https://issues.apache.org/jira/browse/LANG-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574469#action_12574469
 ] 

Niall Pemberton commented on LANG-362:
--------------------------------------

I'm happy with the public API were now exposing to the users and while I 
haven't looked in detail at the code, it is greatly simplified (thanks Matt!) 
and writing a test case for it gives me confidence that it works pretty well. 
So the only outstanding issue is wether we want to suport custom Format 
implementations in sub-formats (i.e. choice) or just document that they are not 
supported. I'm happy either way so I would say if Matt has the time and 
inclination to do it soon then great - otherwise lets just document they are 
not currently supported (in the ExtendedMessageFormat javadocs) and leave if 
for a later release.

> Add ExtendedMessageFormat to org.apache.commons.lang.text
> ---------------------------------------------------------
>
>                 Key: LANG-362
>                 URL: https://issues.apache.org/jira/browse/LANG-362
>             Project: Commons Lang
>          Issue Type: New Feature
>            Reporter: Matt Benson
>            Assignee: Matt Benson
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: DateFormatFactory.java, extendedMessageFormat.patch.txt, 
> extendedMessageFormat.patch.txt, ExtendedMessageFormat2.java, 
> ExtendedMessageFormatTest.java, FormatFactory.java
>
>
> Discussed on dev@ ( 
> http://mail-archives.apache.org/mod_mbox/commons-dev/200710.mbox/[EMAIL 
> PROTECTED] ); adding here for tracking purposes and in case anyone has any 
> serious objections to my implementation.  Patch forthcoming...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to