[ https://issues.apache.org/jira/browse/IO-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575996#action_12575996 ]
Sebb commented on IO-140: ------------------------- Eclipse still complains about: PhantomReference is a raw type. References to generic type PhantomReference<T> should be parameterized commons-io-rw/src/java/org/apache/commons/io FileCleaningTracker.java line 222 ReferenceQueue is a raw type. References to generic type ReferenceQueue<T> should be parameterized commons-io-rw/src/java/org/apache/commons/io FileCleaningTracker.java line 47 ReferenceQueue is a raw type. References to generic type ReferenceQueue<T> should be parameterized commons-io-rw/src/java/org/apache/commons/io FileCleaningTracker.java line 47 ReferenceQueue is a raw type. References to generic type ReferenceQueue<T> should be parameterized commons-io-rw/src/java/org/apache/commons/io FileCleaningTracker.java line 241 Type safety: The constructor PhantomReference(Object, ReferenceQueue) belongs to the raw type PhantomReference. References to generic type PhantomReference<T> should be parameterized commons-io-rw/src/java/org/apache/commons/io FileCleaningTracker.java line 242 It also suggests adding @Override markers to all methods that override others (avoids problems with spelling mistakes etc). Also to add @Deprecated to all deprecated methods (no idea why this is necessary) There's also a whole load of Java 5 fixes that could be made to the test tree as well... > IO 2.0 - Move to JDK 1.5 > ------------------------ > > Key: IO-140 > URL: https://issues.apache.org/jira/browse/IO-140 > Project: Commons IO > Issue Type: Wish > Reporter: Niall Pemberton > Fix For: 2.0 > > Attachments: IO-2.0-deprecate-and-jdk5.patch > > > I just created IO-139 for a StringBuilder Writer implementation that requies > JDK 1.5. So I thought I would look at the impact on IO of 1) Removing all > deprecations and 2) Making appropriate JDK 1.5 changes (generics, using > StringBuilder and new Appendable for Writers). Below is a summary, thought it > could be a starting point for discussion about IO 2.0 > 1) DEPRECATIONS > - CopyUtils > - FileCleaner > - WildcardFilter > - FileSystemUtils freeSpace(String) > - IOUtils toByteArray(String), toString(byte[]), toString(byte[], String) > 2) JDK 1.5 > - ConditionalFileFilter List (and also AndFileFilter and OrFileFilter > implementations > - getFileFilters() and setFileFilters() use generic List<IOFileFilter> > - Constructor for NameFileFilter, PrefixFileFilter, SuffixFileFilter, > WildcardFileFilter use generic List<String> > - replace StringBuffer with StringBuilder where appropriate > (FilenameUtils, FileSystemUtils, HexDump,IOUtils > - FileUtils > - convertFileCollectionToFileArray() --> Collection<File> > - listFiles() --> Collection<File> > - listFiles() --> Collection<File> > - writeStringToFile String-->CharSequence (JDK 1.4+) > - ProxyReader - add read(CharBuffer) > - IOUtils > - readLines(Reader) return List<String> > - toInputStream(String) --> toInputStream(CharSequence) (JDK 1.4+) > - write(String data, OutputStream) and write(StringBuffer data, > OutputStream) --> write(CharSequence data, OutputStream) > - write(String, Writer) and write(StringBuffer, Writer) --> > write(CharSequence data, Writer) > - LineIterator Iterator --> Iterator<String > - NullWriter - add "Appendable" methods > - ProxyWriter - add "Appendable" methods -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.