[jira] Commented: (NET-188) FTPClient#listFiles returns null element when file's timestamp is "02/29"

[Sebb (JIRA)]

    [ 
https://issues.apache.org/jira/browse/NET-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576538#action_12576538
 ] 

Sebb commented on NET-188:
--------------------------

Just found that the test works on Java 1.5 but fails with Java 1.4 (and 
probably 1.3)
Presumably something has changed in the Java 1.5 run-time library.

Since net 1.5 is targetted at Java 1.3 the problem needs to be fixed.

There also clearly need to be test cases for Feb 29.
I think full testing depends on NET-198 being applied, but one can run the 
following Feb 29 test at present:

{code}
    public void testParseFeb29() throws Exception {
        FTPTimestampParserImpl parser = new FTPTimestampParserImpl();
        Calendar cal;
        cal=parser.parseTimestamp("feb 29 20:04");
        int dom = cal.get(Calendar.DAY_OF_MONTH);
        int mon = cal.get(Calendar.MONTH);
        if (dom != 29 || mon != Calendar.FEBRUARY){
            mon++;
            fail("failed to parse Feb 29; gave mon="+mon+" dom="+dom);
        }
    }
{code}

> FTPClient#listFiles returns null element when file's timestamp is "02/29"
> -------------------------------------------------------------------------
>
>                 Key: NET-188
>                 URL: https://issues.apache.org/jira/browse/NET-188
>             Project: Commons Net
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: HONMA Hirotaka
>         Attachments: commons-net-ftp-date-parser-feb29.patch, 
> DstParseTest.java, UnixParseLeapTest.patch
>
>
> This issue has same cause as VALIDATOR-221.
> org.apache.commons.net.ftp.parser.FTPTimestampParserImpl#parseTimestamp 
> throws ParseException with timestampStr = "Feb 29 11:22".
> FTP Server status:
> {code}
> [EMAIL PROTECTED] test-commonsnet]# pwd
> /tmp/test-commonsnet
> [EMAIL PROTECTED] test-commonsnet]# ls -l
> total 0
> -rw-r--r--  1 root root 0 Dec 19  2006 aaa.txt
> -rw-r--r--  1 root root 0 Feb 29 11:22 bbb.txt
> {code}
> test code:
> {code}
> public void testCommonsNetLeapDay() throws Exception {
>     final FTPClient ftp = new FTPClient();
>     ftp.connect(host);
>     ftp.login(user, password);
>     final FTPFile[] listFiles = ftp.listFiles("/tmp/test-commonsnet");
>     for (int i = 0; i < listFiles.length; i++) {
>         System.out.println("[" + i + "] " + listFiles[i]);
>     }
>     ftp.disconnect();
> }
> {code}
> results bellow.
> {code}
> [0] -rw-r--r--    1 0        0               0 Dec 18  2006 aaa.txt
> [1] null
> {code}
> Second element(bbb.txt) should not be null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.