[ https://issues.apache.org/jira/browse/NET-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581653#action_12581653 ]
mhnagaoka edited comment on NET-188 at 3/24/08 12:53 PM: ------------------------------------------------------------------------ Don't you guys think that the piece of code below: {code} if (lenientFutureDates) { // add a day to "now" so that "slop" doesn't cause a date // slightly in the future to roll back a full year. (Bug 35181) now.add(Calendar.DATE, 1); } if (working.after(now)) { working.add(Calendar.YEAR, -1); } {code} should also be executed when the {{hackFormatter}} is used? Rather than only when the {{recentDateFormat}} is used? was (Author: mhnagaoka): Don't you guys think that the piece of code below: {code} if (lenientFutureDates) { // add a day to "now" so that "slop" doesn't cause a date // slightly in the future to roll back a full year. (Bug 35181) now.add(Calendar.DATE, 1); } if (working.after(now)) { working.add(Calendar.YEAR, -1); } {code} should also be executed when the {hackFormatter} is used? Rather than only when the {recentDateFormat} is used? > FTPClient#listFiles returns null element when file's timestamp is "02/29" > ------------------------------------------------------------------------- > > Key: NET-188 > URL: https://issues.apache.org/jira/browse/NET-188 > Project: Commons Net > Issue Type: Bug > Affects Versions: 1.4 > Reporter: HONMA Hirotaka > Attachments: commons-net-ftp-date-parser-feb29.patch, > DstParseTest.java, FTPTimestampParserLeap.patch, jan01.patch > > > This issue has same cause as VALIDATOR-221. > org.apache.commons.net.ftp.parser.FTPTimestampParserImpl#parseTimestamp > throws ParseException with timestampStr = "Feb 29 11:22". > FTP Server status: > {code} > [EMAIL PROTECTED] test-commonsnet]# pwd > /tmp/test-commonsnet > [EMAIL PROTECTED] test-commonsnet]# ls -l > total 0 > -rw-r--r-- 1 root root 0 Dec 19 2006 aaa.txt > -rw-r--r-- 1 root root 0 Feb 29 11:22 bbb.txt > {code} > test code: > {code} > public void testCommonsNetLeapDay() throws Exception { > final FTPClient ftp = new FTPClient(); > ftp.connect(host); > ftp.login(user, password); > final FTPFile[] listFiles = ftp.listFiles("/tmp/test-commonsnet"); > for (int i = 0; i < listFiles.length; i++) { > System.out.println("[" + i + "] " + listFiles[i]); > } > ftp.disconnect(); > } > {code} > results bellow. > {code} > [0] -rw-r--r-- 1 0 0 0 Dec 18 2006 aaa.txt > [1] null > {code} > Second element(bbb.txt) should not be null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.