[
https://issues.apache.org/jira/browse/LANG-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632949#action_12632949
]
Viraj Turakhia commented on LANG-458:
-------------------------------------
Hi Stephen,
I am sorry, I could not find CollectionUtils in [lang]. Please help me in
finding it.
I agree we should not have Validate.isEmpty() if present elsewhere. But should
we not call that method from Validate.notEmpty() so as to avoid code
duplication.
Also, I could not see methods like hasNullElement() in ArrayUtils which, I
think, are very helpful methods and clients might not always want to see
exception being thrown.
Let me know your thoughts.
> Add methods to return boolean from Validate.java instead of throwing
> IllegalArgumentException
> ---------------------------------------------------------------------------------------------
>
> Key: LANG-458
> URL: https://issues.apache.org/jira/browse/LANG-458
> Project: Commons Lang
> Issue Type: Improvement
> Environment: software
> Reporter: Viraj Turakhia
> Priority: Minor
> Attachments: code_diff.txt, test_diff.txt
>
>
> I am using Validate.java since long and find it difficult to use when I just
> want to validate collections or string.
> With current interface, I go like this:
> while(cnt < list.size()) {
> List list1 = list.get(cnt);
> try {
> Validate.notEmpty(list1);
> } catch(IllegalArgumentException e) {
> continue;
> }
> }
> much better approach is:
> while(cnt < list.size()) {
> List list1 = list.get(cnt);
> try {
> if(! Validate.notEmpty(list1)) {
> continue;
> }
> }
> If you all agree with this change, I am willing to submit a patch for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
