[
https://issues.apache.org/jira/browse/DBCP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Thomas resolved DBCP-280.
------------------------------
Resolution: Won't Fix
SequencedHashMap cannot be made final. It is extended by LRUMap.
Yes, the code could be improved. However code correctness is not a sufficient
justification to fork the code when:
- there is no real world bug reported as a result of these issues
- the classes are clearly marked as to lineage and that they are not to be made
public
> SequencedHashMap constructor calls overridable method; throws Error
> -------------------------------------------------------------------
>
> Key: DBCP-280
> URL: https://issues.apache.org/jira/browse/DBCP-280
> Project: Commons Dbcp
> Issue Type: Bug
> Reporter: Sebb
>
> The constructor SequencedHashMap(Map) calls the public non-final method
> putAll().
> This is likely to cause problems if the class is ever extended. Possible
> solution: extract the code into a common private method.
> The next() method also throws an Error if the return type is unexpected.
> It should probably return IllegalStateException or similar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
