[
https://issues.apache.org/jira/browse/DBCP-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688081#action_12688081
]
Phil Steitz commented on DBCP-258:
----------------------------------
I don't see the improvement. Close as WONTFIX?
> [PATCH] ManualPoolingDriverExample - more direct construction of driver and
> minor comment fix
> ---------------------------------------------------------------------------------------------
>
> Key: DBCP-258
> URL: https://issues.apache.org/jira/browse/DBCP-258
> Project: Commons Dbcp
> Issue Type: Improvement
> Affects Versions: 1.2.2
> Reporter: Peter Michaux
> Priority: Minor
> Fix For: 1.3
>
> Attachments: ManualPoolingDriverExamplePatch.diff
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> This example has a very indirect way of registering the driver and getting it
> from the DriverManager.
> Class.forName("org.apache.commons.dbcp.PoolingDriver");
> PoolingDriver driver = (PoolingDriver)
> DriverManager.getDriver("jdbc:apache:commons:dbcp:");
> It is much more direct and clearer to do the following
> PoolingDriver driver = new PoolingDriver();
> DriverManager.registerDriver(driver);
> -------
> There were some missing backslashes in the comments about running the example
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
