[ 
https://issues.apache.org/jira/browse/VFS-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688536#action_12688536
 ] 

Ralph Goers commented on VFS-180:
---------------------------------

Why are all the changes required? I would have thought it could be done simpler 
by changing the hardcoded "http" in WebdavFileProvider to getScheme() as you 
did and then defining a WebdavFileProvider with

public class WebdavsFileProvider extends WebdavFileProvider
{
    public WebdavsFileProvider()
    {
        super();

        setFileNameParser(WebdavsFileNameParser.getInstance());
    }

    protected String getScheme()
    {
        return "https";
    }
}
Then define WebdavsFileNameParser to be pretty much like WebdavFileNameParser 
but have it extend HttpsFileNameParser.  Is there something I am missing?

These should go into a webdavs package, not be comingled in the webdav package.

> Support HTTPS / SSL for Webdav
> ------------------------------
>
>                 Key: VFS-180
>                 URL: https://issues.apache.org/jira/browse/VFS-180
>             Project: Commons VFS
>          Issue Type: New Feature
>    Affects Versions: 1.0, 1.1
>            Reporter: Werner Mueller
>         Attachments: VFS-180.patch, VFS-180.patch
>
>
> The Slide Webdav lib supports encrypted HTTPS connections. So it should be 
> possible to add https support to vfs too. currently the webdav provider 
> creates http urls (in WebdavClientFactory.java).
> maybe some provider like 'webdavs' could be added to switch to HttpsUrl.
> regards
> werner

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to