[ https://issues.apache.org/jira/browse/COMPRESS-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689605#action_12689605 ]
Sebb commented on COMPRESS-55: ------------------------------ I've just created some test files on the people host (7.1-STABLE FreeBSD). In the case of the 'bin' 'newc' and 'crc' formats, the TRAILER record has a link count of 1, namesize 10, and all the other fields are 0. So I think the defaults in the CpioArchiveEntry should also be set to 0. > CpioArchiveEntry ignores invalid modes > -------------------------------------- > > Key: COMPRESS-55 > URL: https://issues.apache.org/jira/browse/COMPRESS-55 > Project: Commons Compress > Issue Type: Bug > Reporter: Sebb > > CpioArchiveEntry has the following code: > {code} > default: > // FIXME: testCpioUnarchive fails if I change the line to > // actually throw the excpetion > new IllegalArgumentException("Unknown mode (full mode: " + mode > + ", masked mode: " + (mode & S_IFMT)); > } > {code} > As the comment says, rejecting invalid modes causes test failures. > These appear to be caused by the code > {bq} this.cpioEntry.setMode(0); > in the method CpioArchiveOutputStream.finish() > Is a mode of 0 allowed? If so, then setMode needs to allow it, otherwise the > method call needs to change to something else. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.