[ 
https://issues.apache.org/jira/browse/DBCP-562?focusedWorklogId=591378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591378
 ]

ASF GitHub Bot logged work on DBCP-562:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Apr/21 06:46
            Start Date: 30/Apr/21 06:46
    Worklog Time Spent: 10m 
      Work Description: fgdrf commented on pull request #38:
URL: https://github.com/apache/commons-dbcp/pull/38#issuecomment-829880497


   > 
   > 
   > Well, since we cannot get rid of the method within a major release, we 
need to workaround that by perhaps making it return always null but only when 
publishing an implementation as a JMX object, which might mean creating a 
wrapper class that delegates all methods except getPassword().
   
   How about creating a new interface, e.g. `IDataSourcePassword `is 
implemented by `BasicDataSource` and `getPassword()` method moves from 
`BasicDataSourceMXBean` to `IDataSourcePassword `. 
   
   Going to update this pull request with this approach ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 591378)
    Time Spent: 1h  (was: 50m)

> Password should not be exposed via JMXBean
> ------------------------------------------
>
>                 Key: DBCP-562
>                 URL: https://issues.apache.org/jira/browse/DBCP-562
>             Project: Commons DBCP
>          Issue Type: Bug
>    Affects Versions: 2.5.0, 2.7.0
>            Reporter: Frank Gasdorf
>            Priority: Critical
>              Labels: security
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> if a BasicDataSource is created with jmxName set, password property is 
> exposed/exported via jmx and is visible for everybody who is connected to jmx 
> port.
>  
> Expectation : Do not export it via BasicDataSourceMXBean Interface



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to