arturobernalg commented on pull request #77:
URL: https://github.com/apache/commons-fileupload/pull/77#issuecomment-830617832


   > I am mostly with you, except for changing
   > 
   > ```
   > assertFalse(condition);
   > ```
   > 
   > to
   > 
   > ```
   > assertTrue(!condition);
   > ```
   > 
   > Would you, please, change that?
   
   I've reverted the change. Even though IMO it's more ease read 
   `assertFalse (conditions)` than `assertTrue(!conditions);` avoing to check 
two conditions. The inner conditions with (!) and the Assert itself


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to