gwlucastrig commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841644514
AFAIK there are two candidates to do the getter: either the Java Rectangle class or implement out own version of the Rectangle. At one point you wanted to avoid java at classes, but in this case, I think Rectangle has advantages On Sat, May 15, 2021, 1:44 AM Bruno P. Kinoshita ***@***.***> wrote: > @gwlucastrig <https://github.com/gwlucastrig> > > great suggestion from @gwlucastrig <https://github.com/gwlucastrig> : > "use one call for setSubImage, rather than 4 separate calls for > setSubImageX, Y, Width, Height." > > I started making this change in the TiffImagingParameter. First the public > void setSubImage(Integer width, Integer height, Integer x, Integer y). > All good so far. > > But when I finished and started adding the getter, I was thinking in > Python or JS, and wanted to return all the 4 parameters at once đŸ˜¥ Then I > realized I would have to create another class to return the 4 parameters… > do you have any suggestion for the getter of the subimage in the tiff > imaging parameter class? > > Thanks! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-imaging/pull/116#issuecomment-841605341>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEWJDYOC6UHIHBYT2C46XRDTNYC5FANCNFSM4WPUJSLQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
