[
https://issues.apache.org/jira/browse/IO-724?focusedWorklogId=610724&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-610724
]
ASF GitHub Bot logged work on IO-724:
-------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/21 15:29
Start Date: 14/Jun/21 15:29
Worklog Time Spent: 10m
Work Description: liran2000 edited a comment on pull request #245:
URL: https://github.com/apache/commons-io/pull/245#issuecomment-860778084
> Thinng about this will be better when after we apply JSR305
>
> If my memory be correct, there be a branch adding these annotations to
suggest Nullable or NotNull.
>
The most important here is to remove the "IllegalArgumentException" if
directory does not exist from the javadoc, which does not match the
implementation condition: if (!directory.exists()) { return;}
Regarding Nullable/NotNull, got it, removed this addition for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 610724)
Time Spent: 40m (was: 0.5h)
> FileUtils.deleteDirectory javadoc is inaccurate for nonexistent directory
> -------------------------------------------------------------------------
>
> Key: IO-724
> URL: https://issues.apache.org/jira/browse/IO-724
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 2.8.0
> Reporter: Henry Tung
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> FileUtils.deleteDirectory javadoc claims:
> {code:java}
> @throws IllegalArgumentException if {@code directory} does not exist or is
> not a directory{code}
> but the first two lines of the code are:
> {code:java}
> Objects.requireNonNull(directory, "directory");
> if (!directory.exists()) {
> return;
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
