[GitHub] [commons-numbers] aherbert commented on a change in pull request #98: Replace assert by simpler but equivalent calls.

[GitBox]

aherbert commented on a change in pull request #98:
URL: https://github.com/apache/commons-numbers/pull/98#discussion_r654896139



##########
File path: 
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
##########
@@ -463,10 +463,10 @@ void testSubtract() {
     @Test
     void testEqualsAndHashCode() {
         final Fraction zero = Fraction.of(0, 1);
-        Assertions.assertTrue(zero.equals(zero));
-        Assertions.assertFalse(zero.equals(null));
-        Assertions.assertFalse(zero.equals(new Object()));
-        Assertions.assertFalse(zero.equals(Double.valueOf(0)));
+        Assertions.assertEquals(zero, zero);
+        Assertions.assertNotEquals(zero, null);
+        Assertions.assertNotEquals(zero, new Object());
+        Assertions.assertNotEquals(zero, (double) 0);

Review comment:
       Do not cast 0 to `double`. This requires an object. Use 
`Double.valueOf(0)`.

##########
File path: 
commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
##########
@@ -625,10 +625,10 @@ void testSubtract() {
     @Test
     void testEqualsAndHashCode() {
         final BigFraction zero = BigFraction.of(0, 1);
-        Assertions.assertTrue(zero.equals(zero));
-        Assertions.assertFalse(zero.equals(null));
-        Assertions.assertFalse(zero.equals(new Object()));
-        Assertions.assertFalse(zero.equals(Double.valueOf(0)));
+        Assertions.assertEquals(zero, zero);
+        Assertions.assertNotEquals(null, zero);
+        Assertions.assertNotEquals(zero, new Object());
+        Assertions.assertNotEquals(zero, Double.valueOf(0), 0.0);

Review comment:
       Remove the delta tolerance here. And two lines above please reverse the 
order of null and zero.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org