[ 
https://issues.apache.org/jira/browse/NUMBERS-166?focusedWorklogId=621262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621262
 ]

ASF GitHub Bot logged work on NUMBERS-166:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jul/21 11:48
            Start Date: 10/Jul/21 11:48
    Worklog Time Spent: 10m 
      Work Description: darkma773r opened a new pull request #101:
URL: https://github.com/apache/commons-numbers/pull/101


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 621262)
    Remaining Estimate: 0h
            Time Spent: 10m

> SortInPlace should not implement BiConsumer
> -------------------------------------------
>
>                 Key: NUMBERS-166
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-166
>             Project: Commons Numbers
>          Issue Type: Improvement
>            Reporter: Matt Juntunen
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{SortInPlace}} enum uses a varargs in the method signature that is not 
> compatible with the {{BiConsumer}} interface that it implements. The 
> interface implementation should be removed and the sort method renamed from 
> {{accept}} to {{apply}} to better reflect that the arguments are being 
> modified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to