[ 
https://issues.apache.org/jira/browse/NUMBERS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378460#comment-17378460
 ] 

Matt Juntunen commented on NUMBERS-166:
---------------------------------------

Done in commit 437432572b9840ebf7b34efa5e0de35971a38f79

> SortInPlace should not implement BiConsumer
> -------------------------------------------
>
>                 Key: NUMBERS-166
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-166
>             Project: Commons Numbers
>          Issue Type: Improvement
>            Reporter: Matt Juntunen
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The {{SortInPlace}} enum uses a varargs in the method signature that is not 
> compatible with the {{BiConsumer}} interface that it implements. The 
> interface implementation should be removed and the sort method renamed from 
> {{accept}} to {{apply}} to better reflect that the arguments are being 
> modified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to