[
https://issues.apache.org/jira/browse/CSV-284?focusedWorklogId=622816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622816
]
ASF GitHub Bot logged work on CSV-284:
--------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/21 01:19
Start Date: 15/Jul/21 01:19
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #168:
URL: https://github.com/apache/commons-csv/pull/168#discussion_r670056091
##########
File path: src/test/java/org/apache/commons/csv/perf/PerformanceTest.java
##########
@@ -85,24 +85,12 @@ private long parse(final Reader reader, final boolean
traverseColumns) throws IO
return recordCount;
}
- private void println(final String s) {
- System.out.println(s);
- }
-
- private long readAll(final BufferedReader in) throws IOException {
Review comment:
I disagree here, keep this as is so it can be commented out or changed
easily when testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 622816)
Time Spent: 20m (was: 10m)
> Formalize PerformanceTest
> -------------------------
>
> Key: CSV-284
> URL: https://issues.apache.org/jira/browse/CSV-284
> Project: Commons CSV
> Issue Type: Improvement
> Reporter: David Mollitor
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There is a class {{org.apache.commons.csv.perf.PerformanceTest}} which is not
> documented and does not work without some hand-edits.
> Re-enable this test, clean it up, and document it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
