[
https://issues.apache.org/jira/browse/COMPRESS-584?focusedWorklogId=633452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633452
]
ASF GitHub Bot logged work on COMPRESS-584:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/21 11:56
Start Date: 04/Aug/21 11:56
Worklog Time Spent: 10m
Work Description: matthijsln edited a comment on pull request #214:
URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892573540
The "no copy buffer" version can be more efficient by only calling
`Arrays.copyOf()` when hitting EOF. This avoids copying the byte array when it
is completely filled:
```
public static byte[] readRange(final ReadableByteChannel input, final
int len) throws IOException {
final ByteBuffer b = ByteBuffer.allocate(len);
while (b.hasRemaining()) {
if (input.read(b) <= 0) {
break;
}
}
if (b.hasRemaining()) {
// We hit EOF and read less bytes, return a smaller array than
len
return Arrays.copyOf(b.array(), b.position());
} else {
return b.array();
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 633452)
Time Spent: 3h 50m (was: 3h 40m)
> IOUtils.readRange() can read more from a channel than asked for
> ---------------------------------------------------------------
>
> Key: COMPRESS-584
> URL: https://issues.apache.org/jira/browse/COMPRESS-584
> Project: Commons Compress
> Issue Type: Bug
> Components: Archivers
> Affects Versions: 1.21
> Reporter: Matthijs Laan
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> When {{IOUtils.readRange(ReadableByteChannel,int)}} gets less than the number
> of bytes asked for in the first read call it does not reduce the buffer size
> for the next read call and may read more than asked for.
> This situation is rare when using a {{FileChannel}} but I wrote a
> {{SeekableByteChannel}} backed by a URI using HTTP range requests and reading
> from a socket can often return less bytes than asked for. When I used this
> channel to read a {{ZipFile}} it only read the ZIP central directory
> partially sometimes because {{IOUtils.readRange()}} called from
> {{ZipFile.readCentralDirectoryEntry()}} read more bytes than asked for and it
> stopped parsing directory entries.
> Fix: [https://github.com/apache/commons-compress/pull/214]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
