[ 
https://issues.apache.org/jira/browse/TEXT-212?focusedWorklogId=634860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634860
 ]

ASF GitHub Bot logged work on TEXT-212:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Aug/21 23:18
            Start Date: 05/Aug/21 23:18
    Worklog Time Spent: 10m 
      Work Description: kinow commented on a change in pull request #233:
URL: https://github.com/apache/commons-text/pull/233#discussion_r683839207



##########
File path: src/test/resources/lcs-perf-analysis-inputs.csv
##########
@@ -0,0 +1,5 @@
+"This code is free software; you can redistribute it and/or modify it","under 
the terms of the GNU General Public License version 2 only, as"
+"You should have received a copy of the GNU General Public License version","2 
along with this work; if not, write to the Free Software Foundation,"
+"Here, the field iterations will be populated with appropriate values from the 
@Param annotation by the JMH when it is passed to the benchmark method. The 
@Setup annotated method is invoked before each invocation of the benchmark and 
creates a new Hasher ensuring isolation. When the execution is finished, we'll 
get a result similar to the one below: When running microbenchmarks, it's very 
important to be aware of optimizations. Otherwise, they may affect 
the","benchmark results in a very misleading way. To make matters a bit more 
concrete, let's consider an example: We expect object allocation costs more 
than doing nothing at all. However, if we run the benchmarks: Apparently 
finding a place in the TLAB, creating and initializing an object is almost 
free! Just by looking at these numbers, we should know that something does not 
quite add up here."
+"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod 
tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, 
quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo 
consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse 
cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non 
proident, sunt in culpa qui officia deserunt mollit anim id est laborum. This 
code is free software; you can redistribute it and/or modify it published by 
the Free Software Foundation.  Oracle designates this This code is distributed 
in the hope that it will be useful, but WITHOUT FITNESS FOR A PARTICULAR 
PURPOSE.  See the GNU General Public License You should have received a copy of 
the GNU General Public License version","Sed ut perspiciatis unde omnis iste 
natus error sit voluptatem accusantium doloremque laudantium, totam rem 
aperiam, eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae 
vitae dicta sunt explicabo. Nemo enim ipsam voluptatem quia voluptas sit 
aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui 
ratione voluptatem sequi nesciunt. Neque porro quisquam est, qui dolorem ipsum 
quia dolor sit amet, consectetur, adipisci velit, sed quia non numquam eius 
modi tempora incidunt ut labore et dolore magnam aliquam quaerat voluptatem. Ut 
enim ad minima veniam, quis nostrum exercitationem ullam corporis suscipit 
laboriosam, nisi ut aliquid ex ea commodi consequatur? Quis autem vel eum iure 
reprehenderit qui in ea voluptate velit esse quam nihil molestiae consequatur, 
vel illum qui dolorem eum fugiat quo voluptas nulla pariatur? under the terms 
of the GNU General Public License version 2 only, as particular file as subject 
to the *Classpath* exception as provided ANY WARRANTY; without even the implied 
warranty of MERCHANTABILITY or version 2 for more details (a copy is included 
in the LICENSE file that 2 along with this work; if not, write to the Free 
Software Foundation,"
+"But I must explain to you how all this mistaken idea of denouncing pleasure 
and praising pain was born and I will give you a complete account of the 
system, and expound the actual teachings of the great explorer of the truth, 
the master-builder of human happiness. No one rejects, dislikes, or avoids 
pleasure itself, because it is pleasure, but because those who do not know how 
to pursue pleasure rationally encounter consequences that are extremely 
painful. Nor again is there anyone who loves or pursues or desires to obtain 
pain of itself, because it is pain, but because occasionally circumstances 
occur in which toil and pain can procure him some great pleasure. To take a 
trivial example, which of us ever undertakes laborious physical exercise, 
except to obtain some advantage from it? But who has any right to find fault 
with a man who chooses to enjoy a pleasure that has no annoying consequences, 
or one who avoids a pain that produces no resultant pleasure? Here, the field 
iterations will be populated with appropriate values from the @Param annotation 
by the JMH when it is passed to the benchmark method. The @Setup annotated 
method is invoked before each invocation of the benchmark and creates a new 
Hasher ensuring isolation. When the execution is finished, we'll get a result 
similar to the one below: When running microbenchmarks, it's very important to 
be aware of optimizations. Otherwise, they may affect the","At vero eos et 
accusamus et iusto odio dignissimos ducimus qui blanditiis praesentium 
voluptatum deleniti atque corrupti quos dolores et quas molestias excepturi 
sint occaecati cupiditate non provident, similique sunt in culpa qui officia 
deserunt mollitia animi, id est laborum et dolorum fuga. Et harum quidem rerum 
facilis est et expedita distinctio. Nam libero tempore, cum soluta nobis est 
eligendi optio cumque nihil impedit quo minus id quod maxime placeat facere 
possimus, omnis voluptas assumenda est, omnis dolor repellendus. Temporibus 
autem quibusdam et aut officiis debitis aut rerum necessitatibus saepe eveniet 
ut et voluptates repudiandae sint et molestiae non recusandae. Itaque earum 
rerum hic tenetur a sapiente delectus, ut aut reiciendis voluptatibus maiores 
alias consequatur aut perferendis doloribus asperiores repellat. benchmark 
results in a very misleading way. To make matters a bit more concrete, let's 
consider an example: We expect object allocation costs more than doing nothing 
at all. However, if we run the benchmarks: Apparently finding a place in the 
TLAB, creating and initializing an object is almost free! Just by looking at 
these numbers, we should know that something does not quite add up here."

Review comment:
       Added missing new line (squashed change-commit)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 634860)
    Time Spent: 20m  (was: 10m)

> A More Efficient Implementation for Calculating Size of Longest Common 
> Subsequence
> ----------------------------------------------------------------------------------
>
>                 Key: TEXT-212
>                 URL: https://issues.apache.org/jira/browse/TEXT-212
>             Project: Commons Text
>          Issue Type: Improvement
>    Affects Versions: 1.9
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 1.10
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Placeholder for [https://github.com/apache/commons-text/pull/233]
> Paper linked and now in Javadoc comments: 
> https://www.ics.uci.edu/~eppstein/161/960229.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to