[
https://issues.apache.org/jira/browse/MATH-1573?focusedWorklogId=635486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635486
]
ASF GitHub Bot logged work on MATH-1573:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 21:03
Start Date: 06/Aug/21 21:03
Worklog Time Spent: 10m
Work Description: aherbert commented on a change in pull request #194:
URL: https://github.com/apache/commons-math/pull/194#discussion_r684502997
##########
File path:
commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java
##########
@@ -1600,9 +1600,8 @@ public static double pow(final double x, final double y) {
z = z * lnb + 1.0;
z *= lnb;
- final double result = exp(lna, z, null);
//result = result + result * z;
- return result;
+ return exp(lna, z, null);
Review comment:
I am wondering about the cryptic commented out code here. It would be
run after the result has been computed with `exp`. So if you simply return the
result of `exp` then the comment is before the `exp` and out of context. I
would leave this unchanged until the reason for commenting out the final
computation is clarified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 635486)
Time Spent: 2h 10m (was: 2h)
> Redundant local variable
> ------------------------
>
> Key: MATH-1573
> URL: https://issues.apache.org/jira/browse/MATH-1573
> Project: Commons Math
> Issue Type: Sub-task
> Reporter: Arturo Bernal
> Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Remove redundant local variable
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
