markt-asf commented on a change in pull request #32:
URL: https://github.com/apache/commons-daemon/pull/32#discussion_r699116202
##########
File path: src/native/windows/src/handles.c
##########
@@ -496,13 +496,15 @@ apxCloseHandle(APXHANDLE hObject)
if (IS_INVALID_HANDLE(hObject) || hObject->dwType ==
APXHANDLE_TYPE_INVALID)
return FALSE;
- /* Call the user callback first */
- (*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
- /* Now go through the callback chain */
- TAILQ_FOREACH(lpCall, &hObject->lCallbacks, queue) {
+ if (!TAILQ_EMPTY(&hObject->lCallbacks)) {
+ /* Call the user callback first */
+ (*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
Review comment:
Why is this inside the test of `lCallbacks`?
##########
File path: src/native/windows/src/handles.c
##########
@@ -496,13 +496,15 @@ apxCloseHandle(APXHANDLE hObject)
if (IS_INVALID_HANDLE(hObject) || hObject->dwType ==
APXHANDLE_TYPE_INVALID)
return FALSE;
- /* Call the user callback first */
- (*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
- /* Now go through the callback chain */
- TAILQ_FOREACH(lpCall, &hObject->lCallbacks, queue) {
+ if (!TAILQ_EMPTY(&hObject->lCallbacks)) {
+ /* Call the user callback first */
+ (*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
Review comment:
As per my comment in DAEMON-336, I'd like to see the steps to reproduce
this so I can dig into what is going on before applying any patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
