kinow commented on pull request #165: URL: https://github.com/apache/commons-imaging/pull/165#issuecomment-917504233
@gwlucastrig here's what I've done in the last commit. 1. Renamed `scansize` to `scanSize` in `ImageDataReader.java` 2. `git commit -am 'f'` (just so I know I need to squash it) 3. `git rebase -i HEAD~2` and I replace `pick f` by `f f` 4. Added an entry in `changes.xml`. This file is used to generate the changelog and in the site and in the `RELEASE-NOTES.txt` file (I think, although can't recall if we use JIRA export tool in release process?). I added an entry with myself as dev, and you as due-to. The dev is always an ASF committer, and due-to the person responsible for work (it's not always present). I didn't put your user as dev as you are still not a committer (only pending you accept & submit the form :) 5. Pushed force a commit with the squashed commit and the `changes.xml` (I can push to your branch as you allowed it when creating the PR) 6. Waited for CI to confirm I didn't mess it up, then merged the PR 7. Updated the JIRA (fix version, status, etc). This is the whole process for a ticket in Imaging, but applies to pretty much every Apache Commons projects too. Cheers Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
