[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=650333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650333
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/21 03:40
Start Date: 14/Sep/21 03:40
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-918771649
Hi @gwlucastrig
Thanks for the detailed example. The only part of the implementation that
bothers me is the static method.
>Finally, each parameters class would implement a static method:
That might become tedious to maintain that code, and also error-prone. Of
course generics can also be error-prone, and are not too simple to maintain.
If only we had a way to combine; make so that users can easily write code
using auto-complete, IDE, etc, in an intuitive way, and in a way that we don't
have any risks in our side (or very low risk of bugs/hard to maintain code)...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 650333)
Time Spent: 9h 40m (was: 9.5h)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
