ali-ghanbari commented on pull request #804: URL: https://github.com/apache/commons-lang/pull/804#issuecomment-920126109
> I have no idea what this new code does as there are ZERO Javadocs, so there is nothing to review from my POV. Thank you for your feedback @garydgregory :) I will add Javadoc asap. This PR adds two methods `floor` (which finds the index of the largest element in the array that is smaller than or equal to the given value) and `ceiling` (which finds the index of the smallest element in the array that is larger than or equal to the given value). These are sorted-array counterparts of floor and ceiling functions in Java's `TreeSet` and `TreeMap`. > There is also a lot of code duplication but I am not sure if lambdas and primitives would mix is an effective manner here. At the time I was writing the code, I could not find a better way to write overloads of the functions for different primitive Java types. Any suggestions is greatly appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
