[
https://issues.apache.org/jira/browse/LANG-1676?focusedWorklogId=666066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-666066
]
ASF GitHub Bot logged work on LANG-1676:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/21 18:23
Start Date: 17/Oct/21 18:23
Worklog Time Spent: 10m
Work Description: Rushi98 commented on a change in pull request #815:
URL: https://github.com/apache/commons-lang/pull/815#discussion_r730455909
##########
File path: src/test/java/org/apache/commons/lang3/RangeTest.java
##########
@@ -306,6 +306,7 @@ public void testIsOverlappedBy() {
// easy inside range
assertTrue(intRange.isOverlappedBy(Range.between(12, 18)));
+ assertTrue(intRange.isOverlappedBy(Range.between(5, 25)));
Review comment:
Hi @garydgregory
Your
[change](https://github.com/apache/commons-lang/commit/ad37cca1caef01cb3d54e479b42d44346f93ac2b#diff-db25bb249ffd66485de1d3a2b394672c04a3554b53d284cef83fa291f7252a51R332)
does make the test case clearer. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 666066)
Time Spent: 0.5h (was: 20m)
> another case for RangeTest.isOverlapped
> ---------------------------------------
>
> Key: LANG-1676
> URL: https://issues.apache.org/jira/browse/LANG-1676
> Project: Commons Lang
> Issue Type: Test
> Components: lang.*
> Reporter: Rushikesh Jogdand
> Priority: Trivial
> Labels: unit-test-missing
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add test for case –
> when other range fully contains this range, this.isOverlapped(other) should
> return true.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
