[jira] [Work logged] (TEXT-211) TextStringBuilder equals method changed behaviour from 1.8 to 1.9

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=675926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675926
 ]

ASF GitHub Bot logged work on TEXT-211:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Nov/21 01:41
            Start Date: 04/Nov/21 01:41
    Worklog Time Spent: 10m 
      Work Description: kinow commented on a change in pull request #281:
URL: https://github.com/apache/commons-text/pull/281#discussion_r742269475



##########
File path: src/main/java/org/apache/commons/text/TextStringBuilder.java
##########
@@ -1850,7 +1850,14 @@ public boolean equals(final Object obj) {
      * @return true if the builders contain the same characters in the same 
order
      */
     public boolean equals(final TextStringBuilder other) {
-        return other != null && Arrays.equals(buffer, other.buffer);
+       
+       if(other == null) {
+               return false;
+       }
+       if (this.size != other.size) {
+            return false;
+        }
+        return Arrays.equals(ArrayUtils.subarray(buffer, 0, size), 
ArrayUtils.subarray(other.buffer, 0, size));

Review comment:
       Bad formatting here 👆




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 675926)
    Time Spent: 2h 50m  (was: 2h 40m)

> TextStringBuilder equals method changed behaviour from 1.8 to 1.9
> -----------------------------------------------------------------
>
>                 Key: TEXT-211
>                 URL: https://issues.apache.org/jira/browse/TEXT-211
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.9
>            Reporter: Nikolaos Georgiou
>            Priority: Major
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> We found a regression (or breaking compatibility change) in the 
> TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9
>  
> The 1.8 version ( 
> [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915]
>  ) would only compare the parts of the buffer that fall within the range 
> 0..size.
> The 1.9 version ( 
> [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855]
>  ) compares the entire buffer arrays.
> If a TextStringBuilder has extra capacity in the buffer, comparison fails.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)