[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=676973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-676973
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/21 10:52
Start Date: 05/Nov/21 10:52
Worklog Time Spent: 10m
Work Description: kinow edited a comment on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-961796289
That is a good point @gwlucastrig , and I have no objections to massaging
the code of the `Imaging` class. I will spend some time thinking about that,
and seeing if/when the parameters would be useful or not. Thanks!!! (and you
have a perspective of user + dev, which is really valuable @gwlucastrig !)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 676973)
Time Spent: 13h 20m (was: 13h 10m)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
