[ https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=689990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689990 ]
ASF GitHub Bot logged work on IMAGING-159: ------------------------------------------ Author: ASF GitHub Bot Created on: 03/Dec/21 13:11 Start Date: 03/Dec/21 13:11 Worklog Time Spent: 10m Work Description: darkma773r commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-985507050 Cool! I'll try to take a look at this over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 689990) Time Spent: 15h 20m (was: 15h 10m) > There should be a Parameters class > ---------------------------------- > > Key: IMAGING-159 > URL: https://issues.apache.org/jira/browse/IMAGING-159 > Project: Commons Imaging > Issue Type: Improvement > Components: imaging.* > Affects Versions: 1.0-alpha2 > Reporter: Benedikt Ritter > Assignee: Bruno P. Kinoshita > Priority: Major > Labels: github > Fix For: 1.0-alpha3 > > Time Spent: 15h 20m > Remaining Estimate: 0h > > Currently options for image I/O are defined as Maps. The leads to the problem > that our code has to validate parameter types when they are used: > {code:java} > final Object value = params.get(PARAM_KEY_COMPRESSION); > if (value != null) { > if (!(value instanceof Number)) { > throw new ImageWriteException( > "Invalid compression parameter, must be numeric: " > + value); > } > compression = ((Number) value).intValue(); > } > {code} > This can be simplified if we define a Parameters class that provides > additional methods like {{public int getInt(String key)}}. The implementation > could then look up the value from the map through an exception if it is null > or not a number. -- This message was sent by Atlassian Jira (v8.20.1#820001)