garydgregory commented on a change in pull request #766:
URL: https://github.com/apache/commons-lang/pull/766#discussion_r763142047
##########
File path: src/main/java/org/apache/commons/lang3/LocaleUtils.java
##########
@@ -248,7 +250,9 @@ private static Locale parseLocale(final String str) {
return new Locale(str);
}
- final String[] segments = str.split("_", -1);
+ final String[] segments = str.indexOf(DASH) != -1
+ ? str.split(String.valueOf(DASH), -1)
Review comment:
Does it matter that dash is tested before underscore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
