Claudenw commented on pull request #258:
URL:
https://github.com/apache/commons-collections/pull/258#issuecomment-995973702
@aherbert,
I will look at changing the interface to return `long` index values rather
than `integer`.
I will insert your code to convert a BitMapProducer to an IndexProducer and
verify that the tests still work.
I think `asIndexArray` can be modified so that it checks the cardinality()
of the filter to get the size of the returned array, then the population should
be much quicker and smoother. I will look into this.
Now to your comments on `contains()`. I understand the issue you raise.
However I am not certain I understand the solution you explore. Are you
suggesting that IndexProducer implements a `forEachIndex` that takes an
`IndexConsumer` rather than an `IntConsumer` and that it simply stop processing
when the `IndexConsumer` returns false? If so, than would it not be just as
correct to use an `IntPredicate`?
Am I following your suggestion correctly or am I on the wrong track
completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
