[
https://issues.apache.org/jira/browse/LANG-1675?focusedWorklogId=709493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709493
]
ASF GitHub Bot logged work on LANG-1675:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jan/22 11:46
Start Date: 15/Jan/22 11:46
Worklog Time Spent: 10m
Work Description: HubertWo commented on pull request #812:
URL: https://github.com/apache/commons-lang/pull/812#issuecomment-1013668022
@garydgregory, @kinow thank you for testing!
Regarding code suggestions. I've changed ```deleteCharAt``` to
```substring``` and set fixed size of ```StringBuilder``` to ```join(char)```
and ```join(boolean)```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 709493)
Time Spent: 4h 40m (was: 4.5h)
> Improve performance of StringUtils.join for primitives.
> -------------------------------------------------------
>
> Key: LANG-1675
> URL: https://issues.apache.org/jira/browse/LANG-1675
> Project: Commons Lang
> Issue Type: Improvement
> Reporter: Hubert Wojciechowski
> Priority: Minor
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> This is [~XenoAmess] comment from PR:
> [https://github.com/apache/commons-lang/pull/784]
> {noformat}
> Please look at the sources in JDK, where
> java.lang.AbstractStringBuilder#append(boolean b)
> In short, for basic types, should not convert them to String, but use
> StringBuilder directly, will bring far better performance.
> BUT I just foundout that you did not bring this issue, this issue is already
> in commons-lang before your pr.
> So I will not stop you from merging this in, but still I will find time to
> refactor the whole join serial functions later.
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
