[
https://issues.apache.org/jira/browse/IMAGING-325?focusedWorklogId=713222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713222
]
ASF GitHub Bot logged work on IMAGING-325:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/22 14:41
Start Date: 22/Jan/22 14:41
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #196:
URL: https://github.com/apache/commons-imaging/pull/196#discussion_r790149061
##########
File path:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java
##########
@@ -385,6 +385,10 @@ private BmpImageContents readImageContents(final
InputStream is,
+ bhi.compression);
}
+ if (paletteLength < 0) {
+ throw new ImageReadException("Invalid negative palette length: " +
paletteLength);
Review comment:
Also, isn't the underlying issue that the colorTableSize is negative?
Shouldn't we check that instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 713222)
Time Spent: 20m (was: 10m)
> Prevent possible OOM error in BmpImageParser
> --------------------------------------------
>
> Key: IMAGING-325
> URL: https://issues.apache.org/jira/browse/IMAGING-325
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: BMP
> Reporter: Bruno P. Kinoshita
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
