[
https://issues.apache.org/jira/browse/COLLECTIONS-803?focusedWorklogId=732633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732633
]
ASF GitHub Bot logged work on COLLECTIONS-803:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/22 19:51
Start Date: 24/Feb/22 19:51
Worklog Time Spent: 10m
Work Description: Simulant87 commented on pull request #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1050206636
@freya022 thank you for your suggestion. This sounds like another high
performance improvement.
However it also sounds like the behaviour might slightly change in some edge
cases. Something I expect the maintainers want to avoid and could cause a
longer discussion. Therefore I would like to keep your suggestion separated
from my changes. As my implementation does not cahnge the behaviour of the key
conversion, it should be simpler to review and approve. I encourage your to
create a ticket in
[Jira](https://issues.apache.org/jira/projects/COLLECTIONS/issues) and create a
separate pull request for that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 732633)
Time Spent: 1h 10m (was: 1h)
> CaseInsensitiveMap prevent duplicate key conversion on put
> ----------------------------------------------------------
>
> Key: COLLECTIONS-803
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-803
> Project: Commons Collections
> Issue Type: Improvement
> Components: Map
> Affects Versions: 4.4
> Reporter: Simulant
> Priority: Minor
> Labels: performance
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When adding a new item into a {{CaseInsensitiveMap}} the {{convertKey(key)}}
> method is called twice, once in the {{put(key, value)}} method and second in
> the {{createEntry(next, hashCode, key, value)}} method. The result could be
> re-used resulting in a better performance.
> Depending on the {{toString()}} implementation of the key and the resulting
> length of the key before the lower case conversion the operation can get
> expensive and should not be called twice, as the {{CaseInsensitiveMap}}
> overwrites the {{convertKey(key)}} method and makes it more expensive and
> depending on the input unlike in the implementation of the
> {{AbstractHashedMap}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
