mbuiakova commented on pull request #863: URL: https://github.com/apache/commons-lang/pull/863#issuecomment-1059996750
> Would you please explain why this is needed? > > Also: > > * there are no tests > * the code has superfluous parentheses I added a test and removed extra parentheses. The reason for these changes is that Calendar has timeZone, so it is expected by a user of the `format(final Calendar calendar, final String pattern)`-like methods that method gets the timezone from a calendar object. More detailed explanation [here](https://issues.apache.org/jira/browse/LANG-1462). Can you help please with this error, how to deal with it? ``` Error: High: Null passed for non-null parameter of format(Calendar, String, TimeZone, Locale) in org.apache.commons.lang3.time.DateFormatUtils.format(Calendar, String) [org.apache.commons.lang3.time.DateFormatUtils, org.apache.commons.lang3.time.DateFormatUtils] Method invoked at DateFormatUtils.java:[line 283]Known null at DateFormatUtils.java:[line 283] NP_NULL_PARAM_DEREF ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
