[
https://issues.apache.org/jira/browse/COMPRESS-614?focusedWorklogId=745334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745334
]
ASF GitHub Bot logged work on COMPRESS-614:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 18:11
Start Date: 21/Mar/22 18:11
Worklog Time Spent: 10m
Work Description: andrebrait commented on a change in pull request #256:
URL: https://github.com/apache/commons-compress/pull/256#discussion_r831407462
##########
File path:
src/main/java/org/apache/commons/compress/archivers/zip/X000A_NTFS.java
##########
@@ -244,6 +245,36 @@ public Date getCreateJavaTime() {
return zipToDate(createTime);
}
+ /**
+ * Returns the modify time as as a {@link FileTime}
Review comment:
Fixed
##########
File path:
src/test/java/org/apache/commons/compress/archivers/sevenz/SevenZFileTest.java
##########
@@ -836,4 +857,37 @@ private void checkHelloWorld(final String filename) throws
Exception {
private static boolean isStrongCryptoAvailable() throws
NoSuchAlgorithmException {
return Cipher.getMaxAllowedKeyLength("AES/ECB/PKCS5Padding") >= 256;
}
+
+ private void assertDates(SevenZArchiveEntry e, String modified, String
access, String creation) {
+ if (modified != null) {
+ assertTrue(e.getHasLastModifiedDate());
+ FileTime time = FileTime.from(Instant.parse(modified));
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 745334)
Time Spent: 50m (was: 40m)
> Use FileTime for time fields in SevenZipArchiveEntry
> ----------------------------------------------------
>
> Key: COMPRESS-614
> URL: https://issues.apache.org/jira/browse/COMPRESS-614
> Project: Commons Compress
> Issue Type: Improvement
> Components: Archivers
> Affects Versions: 1.21
> Reporter: Andre Brait
> Priority: Major
> Labels: 7zip
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Instead of java.util.Date, which caps precision in milliseconds, let's move
> on to using FileTime.
> We can keep backwards compatibility through the getters and setters for
> modification, access and creation dates.
> If you're ok with it, I'll send a PR for this.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
