[GitHub] [commons-codec] garydgregory commented on a diff in pull request #126: Avoid use toString() or substring() in favor of a simplified expression.

[GitBox]

garydgregory commented on code in PR #126:
URL: https://github.com/apache/commons-codec/pull/126#discussion_r851755311


##########
src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java:
##########
@@ -403,7 +403,7 @@ public String encode(String input, final 
Languages.LanguageSet languageSet) {
         input = input.toLowerCase(Locale.ENGLISH).replace('-', ' ').trim();
 
         if (this.nameType == NameType.GENERIC) {
-            if (input.length() >= 2 && input.substring(0, 2).equals("d'")) { 
// check for d'
+            if (input.length() >= 2 && input.startsWith("d'")) { // check for 
d'

Review Comment:
   @arturobernalg 
   Why still check for length >=2 ? What is change automatically generated 
through IntelliJ or Eclipse?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org