[ https://issues.apache.org/jira/browse/COLLECTIONS-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527209#comment-17527209 ]
Ben Manes commented on COLLECTIONS-802: --------------------------------------- Thanks! Can you run {{ApacheMapTest}} locally then to make sure that your changes didn't break something else? > ReferenceMap iterator remove violates contract > ---------------------------------------------- > > Key: COLLECTIONS-802 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-802 > Project: Commons Collections > Issue Type: Bug > Components: Map > Affects Versions: 4.4 > Reporter: Ben Manes > Priority: Minor > Attachments: ApacheMapTest.java > > Time Spent: 10m > Remaining Estimate: 0h > > Out of curiosity I ran Guava's testlib Map tests against the Apache types. > This uncovered a contract bug where {{Iterator.remove()}} is invalidated by > {{{}hasNext(){}}}, causing its call to no-op due to {{currentKey}} becoming > {{{}null{}}}. The isolates case is, > {code:java} > @Test > public void iterator_remove() { > var map = new ReferenceMap<>(); > map.put(1, 2); > var iter = map.entrySet().iterator(); > assertTrue(iter.hasNext()); > assertTrue(iter.hasNext()); > assertEquals(iter.next(), 1); > assertFalse(iter.hasNext()); > iter.remove(); > assertEquals(map, Map.of()); > }{code} > Guava's [testlib|https://github.com/google/guava/tree/master/guava-testlib] > has good coverage for the Collections Framework and might be worth > integrating. The simple test case that I wrote is attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)