[GitHub] [commons-collections] kinow commented on pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe…

Sun, 24 Apr 2022 19:43:39 -0700 


kinow commented on PR #300:
URL: 
https://github.com/apache/commons-collections/pull/300#issuecomment-1108007330

   Thanks @ben-manes, much easier now to run the tests and compare the results 
with your updated test.
   
   For `master`:
   
   ```bash
   [ERROR] Failures: 
   [ERROR]   
CollectionIteratorTester.testIterator_unknownOrderRemoveSupported:111->runIteratorTest:133
 failed with stimuli [hasNext, hasNext, next, hasNext, remove]
   [ERROR]   
CollectionIteratorTester.testIterator_unknownOrderRemoveSupported:111->runIteratorTest:133
 failed with stimuli [hasNext, hasNext, next, hasNext, remove]
   [ERROR]   
CollectionIteratorTester.testIterator_unknownOrderRemoveSupported:111->runIteratorTest:133
 failed with stimuli [hasNext, hasNext, next, hasNext, remove]
   [ERROR]   
CollectionIteratorTester.testIterator_unknownOrderRemoveSupported:111->runIteratorTest:133
 failed with stimuli [next, next, next, hasNext, remove]
   [ERROR]   
CollectionIteratorTester.testIterator_unknownOrderRemoveSupported:111->runIteratorTest:133
 failed with stimuli [next, next, next, hasNext, remove]
   [ERROR]   
CollectionIteratorTester.testIterator_unknownOrderRemoveSupported:111->runIteratorTest:133
 failed with stimuli [next, next, next, hasNext, remove]
   [INFO] 
   [ERROR] Tests run: 25518, Failures: 6, Errors: 0, Skipped: 4
   [INFO] 
   ```
   
   Then for this branch:
   
   ```bash
   [INFO] Results:
   [INFO] 
   [WARNING] Tests run: 25520, Failures: 0, Errors: 0, Skipped: 4
   ```
   So no regressions in our CI, nor in the `ApacheMapTest` after this change 
:clap: 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to