garydgregory commented on PR #350: URL: https://github.com/apache/commons-io/pull/350#issuecomment-1123083646
Hello @saiple, -1. I am am sorry but this code seems flawed and not in the right home. It seems too easy to break an app on exit or at time really. It's hard to tell of course since this PR has zero unit tests so use cases are imaginary at this point. It seems that little or no thought was given to concurrency issues, for example, the use of a concurrent unsafe list, use of non-daemon threads, threads updating a global variable. IMO, the "lines of code" argument is not relevant since you can abstract these in a method in your app. I am not a fan of duplicating this kind of functionality across IO and VFS. In my mind, IO is a low level library and VFS is a higher level library where I see this type of functionality residing. I am curious to learn what others think. What is also problematic IMO is the use of a global variable to track threads as well as the other issues mentioned. So -1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
