[ https://issues.apache.org/jira/browse/CRYPTO-162?focusedWorklogId=781134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781134 ]
ASF GitHub Bot logged work on CRYPTO-162: ----------------------------------------- Author: ASF GitHub Bot Created on: 14/Jun/22 12:11 Start Date: 14/Jun/22 12:11 Worklog Time Spent: 10m Work Description: wenwj0 commented on code in PR #165: URL: https://github.com/apache/commons-crypto/pull/165#discussion_r896736961 ########## src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java: ########## @@ -60,6 +60,11 @@ public OpenSslCipher(final Properties props, final String transformation) // NOP } openSslEngine = OpenSsl.getInstance(transformation); + + String engineId = props.getProperty(CryptoCipherFactory.CIPHER_ENGINE_KEY); + if(engineId != null && !engineId.isEmpty()) { Review Comment: ok ########## src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java: ########## @@ -378,4 +378,7 @@ protected void finalize() throws Throwable { clean(); } + public void engineSetDefaultCiphers(String engineId){ Review Comment: ok Issue Time Tracking ------------------- Worklog Id: (was: 781134) Time Spent: 1.5h (was: 1h 20m) > openSslCipher support engine > ---------------------------- > > Key: CRYPTO-162 > URL: https://issues.apache.org/jira/browse/CRYPTO-162 > Project: Commons Crypto > Issue Type: New Feature > Components: Cipher > Reporter: wenweijian > Priority: Minor > Time Spent: 1.5h > Remaining Estimate: 0h > > The engine is the hardware or software implementation used for performing > cryptographic operations. > > Assume we have a hardware device with a super fast implementation of AES. Now > when we use AES encryption we can set the engine to that hardware device > (instead of {{{}NULL{}}}), which means that the operations are now computed > by the hardware device instead of the default OpenSSL software layer. > -- This message was sent by Atlassian Jira (v8.20.7#820007)