[ 
https://issues.apache.org/jira/browse/LANG-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830713#action_12830713
 ] 

Sebb commented on LANG-588:
---------------------------

Why do you need readObject()? Surely the hashCode could just be serialised 
along with the objects?

If readObject() really is needed, then hashCode needs to be made volatile.
Otherwise make it final.

I think it would be helpful to expand the class Javadoc to include some use 
cases for the class.

> Create a basic Pair<L, R> class
> -------------------------------
>
>                 Key: LANG-588
>                 URL: https://issues.apache.org/jira/browse/LANG-588
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>            Reporter: Matt Benson
>             Fix For: 3.0
>
>         Attachments: MatchedPair.java, MatchedPairTest.java, Pair.java, 
> PairTest.java
>
>
> [lang] is the perfect place to provide a basic typed Pair class.  I have 
> written such a class for my employer (who hasn't?) but can/will rewrite blind 
> to avoid IP issues.  I think it's also nice to go ahead and extend this to 
> MatchedPair<T> extends Pair<T, T> as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to